Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Replace pdfminer3k with pypdf #994

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Fixes #964

Description of changes

pdfminer3k is not maintained for a few years now. In this PR, I am replacing it with pypdf, which looks maintained and is a pure Python package.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title [FIX] [FIX] Replace pdfminer3k with pypdf Aug 8, 2023
@PrimozGodec PrimozGodec force-pushed the replace-pypdf branch 2 times, most recently from 9ecae19 to 2cdf702 Compare August 8, 2023 10:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #994 (1cb5734) into master (96a9548) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   82.20%   82.06%   -0.14%     
==========================================
  Files          93       93              
  Lines       12284    12264      -20     
  Branches     1664     1661       -3     
==========================================
- Hits        10098    10065      -33     
- Misses       1874     1889      +15     
+ Partials      312      310       -2     

@PrimozGodec
Copy link
Collaborator Author

/rebase

@PrimozGodec
Copy link
Collaborator Author

/rebase

@ajdapretnar ajdapretnar merged commit 139eedf into biolab:master Nov 10, 2023
10 of 12 checks passed
@PrimozGodec PrimozGodec deleted the replace-pypdf branch November 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing pdfminer3k dependency with pdfminer.six
5 participants